This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug libstdc++/59406] functions labelled FNV-1a in tr1/functional_hash.h are not FNV-1a
- From: "redi at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: Tue, 31 Mar 2015 14:34:02 +0000
- Subject: [Bug libstdc++/59406] functions labelled FNV-1a in tr1/functional_hash.h are not FNV-1a
- Auto-submitted: auto-generated
- References: <bug-59406-4 at http dot gcc dot gnu dot org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59406
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-03-31
Ever confirmed|0 |1
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to g1 from comment #2)
> Don't know if those functions are used somewhere or are leftovers. The
> comments in the file suggest that Murmur hash is used in the std::hash
> template instead of FNV-1a.
They're just leftovers retained for backwards compatibility in applications
that need the old hashing algorithm, so changing them is probably not a good
idea as it would not be backwards compatible.
I'll add a comment to libsupsc++/hash_bytes.cc saying it's not really FNV-1a
but I don't think we should change it now.
Thanks for pointing it out though.