This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug bootstrap/65150] [5 Regression] r220875 causes bootstrap failure on x86_64 darwin


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65150

--- Comment #14 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Martin LiÅka from comment #13)
> (In reply to Dominique d'Humieres from comment #8)
> > On I also see
> > 
> > FAIL: c-c++-common/attr-used.c  -std=gnu++(11|14|98)  scan-assembler
> > function_declaration_before
> > 
> > or
> > 
> > FAIL: c-c++-common/attr-used.c  -Wc++-compat   scan-assembler
> > function_declaration_before
> 
> Hello.
> 
> I've just analyzed both these test cases (iinline-5.c and attr-used) and
> both situations looks correctly from my point of view:
> 
> If target does not support alias support in iinline-5.c, ICF optimization
> creates a thunk that inliner refuses to inline.
> 
> Similar situation for attr-used.c, where as we call condition
> redirect_callers and alias has no reference
> (_ZL27function_declaration_beforev), thus the symbol is removed.
> 
> I've been running complete c/c++ testsuite on x86_64-linux-pc (with disable
> alias support) and if it passes (modulo these testcases), I would like to
> apply Jakub's patch.

thanks for looking at these.

FWIW, LGTM (with suitable guards added to the tests for the target alias
support).
(I cannot officially approve of course ;) )
 ... if we find other regressions a new PR can be opened.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]