This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug c/61861] Incorrect column number for -Wdiscarded-qualifiers
- From: "dodji at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: Fri, 08 Aug 2014 16:06:45 +0000
- Subject: [Bug c/61861] Incorrect column number for -Wdiscarded-qualifiers
- Auto-submitted: auto-generated
- References: <bug-61861-4 at http dot gcc dot gnu dot org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61861
Dodji Seketeli <dodji at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dodji at gcc dot gnu.org
Resolution|FIXED |DUPLICATE
--- Comment #8 from Dodji Seketeli <dodji at gcc dot gnu.org> ---
Hello,
I was on the road when this patch was submitted so I missed it. Sorry.
It looks too like this issue is related to PR61817. I even sent a patch for
this at http://comments.gmane.org/gmane.comp.gcc.patches/316794 but then later
you sent your patch and it went in :-)
I think the initial patch I sent solves this issue as well. Both of our
patches have a something common: they make builtin_macro() take an additional
parameter that is the location of the expansion point of the built-in macro we
are looking at.
One the differences in handling is that you set the token->src_loc to the
location of the expansion point of the built-in macro; but then normally, the
convention is that that token->src_loc must always be spelling location. It
must never be a virtual location. And the issue is that the location of the
expansion point can be a virtual location. So we should not set token->src_loc
like that, I think.
But do not worry; I'll update the patch, test it, submit it and keep you guys
posted.
Cheers.
*** This bug has been marked as a duplicate of bug 61817 ***