This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug c/7652] -Wswitch-break : Warn if a switch case falls through


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #17 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Daniel MarjamÃki from comment #7)
> In my experience this type of check is really noisy if there is a warning
> for every fall through.
> 
> I recommend that the warning is written only if the fall through cause
> redundant or bad behaviour. such as:
> 
>     switch (foo) {
>     case 1: x = y;   // <- redundant assignment
>     case 2: x = z;
>     };

I'd be happy with gcc warning for this kind of problem.

This specific case should be easier to catch than the 
general case.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]