This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug c++/52961] Missing warning on empty if


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52961

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-10-09 16:41:17 UTC ---
Then, likely this could be resolved very quickly but what in means exactly to
have the warning by default here? Change:

            if (!cp_lexer_next_token_is_keyword (parser->lexer, RID_ELSE))
          warning_at (loc, OPT_Wempty_body, "suggest braces around "
                  "empty body in an %<if%> statement");

to

            if (!cp_lexer_next_token_is_keyword (parser->lexer, RID_ELSE))
          warning_at (loc, 0, "suggest braces around "
                  "empty body in an %<if%> statement");

?? It makes sense to me because I don't think somebody may want to suppress the
warning and keep this kind of code, but wanted to confirm.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]