[Bug bootstrap/49555] libjava fails to configure if --enable-symvers=gnu or --enable-symvers=sun

["bryanhundven at gmail dot com" <gcc-bugzilla at gcc dot gnu dot org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49555

--- Comment #7 from Bryan Hundven <bryanhundven at gmail dot com> 2011-06-29 19:30:03 UTC ---
(In reply to comment #6)
> > I had a discussion with Yann E. Morin, and it sounds like this option was
> > ported forward from the legacy options in Dan Kegel's crosstool.
> >
> > The questions I am asking should be:
> >
> > * Should this ever (for any platform) be set manually? Or should this always be
> > an 'automatic' setting?
> 
> Except for the (experimental) gnu vs. gnu-versioned-namespace
> distinction in libstdc++-v3, I don't believe so.  We had a case where
> --disable-symvers/--enable-symvers=no was necessary as a workaround, but
> otherwise I'd prefer users to leave this alone.  Unfortunately, the
> configure checks in different target libraries are currently
> inconsistent.  I hope to get back to this at some point, though.

Ok. Thanks for the explanation!

> > * Isn't it inconsistent that every component checks for 'gnu*' and 'sun',
> > except for libjava?
> 
> In a way, it is, except that it matters for those components, but not
> for libjava.  But the check should be for gnu and sun alone,
> gnu-versioned-namespace is probably wrong here.
> 
> > Yann is currently retesting the sh4 build without --enable-symvers=gnu set to
> > see if it still needs it. If it does not, then he will remove it completely,
> > otherwise it should be target specific in crosstool-ng and not for all targets.
> 
> Excellent, thanks for checking this.
> 
>     Rainer

So, Yann found that sh4 did not need this option anymore, and he has since
removed the --enable-symvers option from the build:

http://crosstool-ng.org/hg/crosstool-ng/rev/b24ead1a5947

So now we just let gcc figure it out.

As for the inconsistent check in libjava and the previous change to remove
enable-symvers from ct-ng in mind, this can probably be resolved as invalid
unless you'd like to just add gnu|sun to the
libjava_cv_anon_version_script=yes;; case. (attaching patch to give an
example).

wrt all of the extra configuration options, it would be very appreciated if in
another thread we could discuss some of them. I'm sure a lot of the options we
have for building binutils and gcc are ported forward from the older crosstool
scripts and aren't needed anymore. My theory on that has been: if it ain't
broke, don't fix it
...until now.