This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug c/43553] libgcc built with -DHAVE_CC_TLS against xgcc when emutls in use
- From: "bonzini at gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: 4 Apr 2010 07:18:02 -0000
- Subject: [Bug c/43553] libgcc built with -DHAVE_CC_TLS against xgcc when emutls in use
- References: <bug-43553-11113@http.gcc.gnu.org/bugzilla/>
- Reply-to: gcc-bugzilla at gcc dot gnu dot org
------- Comment #24 from bonzini at gnu dot org 2010-04-04 07:18 -------
Subject: Re: libgcc built with -DHAVE_CC_TLS against xgcc when
emutls in use
> This provides a traverse of the emutls control var htab finalizing
> each.
>
> I didn't try to check if vars were already finalized in the traversal
> callback - on the basis that varpool_finalize_decl is efficient at
> that itself.
>
> Additional: following Paolo's comments on gcc I've updated
> emutls_decl() to copy: TREE_ADDRESSABLE, DECL_VISIBILITY_SPECIFIED,
> DECL_PRESERVE_P and DECL_INITAL.
The patch makes sense, only I'm not entirely sure copying the other
three fields is correct. I'd have to see exactly how emutls decls are
used to review that.
For now, I'd update it to copy only DECL_VISIBILITY_SPECIFIED if it
works (as I interpret your comment that fixing emutls_decl was
"additional"), and leave the rest for 4.6.
Paolo
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43553