This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug c++/37012] numerous stackalign related testsuite failures on i686-apple-darwin9



------- Comment #25 from hjl dot tools at gmail dot com  2008-08-04 12:46 -------
(In reply to comment #19)
> I'll check eh-alloca-1.C shortly. Do you think we should also have...
> 
> --- i386.c.org  2008-08-03 22:55:01.000000000 -0400
> +++ i386.c      2008-08-03 22:56:07.000000000 -0400
> @@ -7242,7 +7242,7 @@
>    preferred_alignment = crtl->preferred_stack_boundary / BITS_PER_UNIT;
> 
>    gcc_assert (!size || stack_alignment_needed);
> -  gcc_assert (preferred_alignment >= STACK_BOUNDARY / BITS_PER_UNIT);

That is correct. Since STACK_BOUNDARY is required by MacOS, you
don't want to set stack alignment less than the one specified by
ABI.

> +  gcc_assert (preferred_alignment >= UNITS_PER_WORD);

That is wrong.

>    gcc_assert (preferred_alignment <= stack_alignment_needed);
> 
>    /* During reload iteration the amount of registers saved can change.
> 
> It didn't fix the issue but seems to be of identical form as the other changes.
> Also,
> what about instances of the same construct in the gcc/gcc subdirectory (outside
> of
> gcc/gcc/config/i386)?
> 

I think they are OK.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37012


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]