This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug rtl-optimization/33796] valgrind error with -O2 for linux kernel code



------- Comment #14 from hp at gcc dot gnu dot org  2008-01-12 23:05 -------
(In reply to comment #9)
> i personally think that this patch in #8 is not the right way to go.
> 
> unless there is a compelling argument that initializing this is going to have
> some negative performance effect, we should properly initialize this
> datastructure as we do (or at least try to do) for every other data structure
> in the compiler.  While the current code that peter has written is correct, it
> is quite tricky.  This compiler has way too much tricky code, which only adds
> to the long term maintainance cost of the compiler.
> 
> the patch in 8 is not acceptable because it requires that the compiler be built
> in a particular way to avoid the valgrind errors.  The last thing that you want
> to have to do if you have a heisenbug is to rebuild your compiler in a way that
> will change the layout and alignment of things.  

You know, that patch *enables*, it does not *require*.  Nothing forces it to be
the end of the story regarding this code, or that this PR be closed with it
applied.  It doesn't stop anyone (like you) from actually changing the way that
code looks.  It does however, enable people to build and test using
--enable-checking=valgrind, like it could before (making the current behavior a
regression).  Other people, in particular, write-privilege maintainers of the
code in question, have expressed sentiments that the patch was the way to go. 
You want to *stop* the patch because it doesn't *help* with an odd special
case?  Well, it helps with other debug cases, so let's have progress, and not
have the perfect stand in way of gradual improvement.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33796


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]