This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libfortran/19524] 5 times uninitialized var in libgfortran


------- Additional Comments From tobi at gcc dot gnu dot org  2005-01-22 00:36 -------
The first four can be fixed by slightly reordering the contents of the functions
they're in.  I'm not proposing a patch, because I'm not completely sure why that
code is needed, and I'm too tired to look into this right now.  For the error in
read.c this patch should be sufficient, there's no path leading to bad_float on
which buffer is initialized.  I will regtest this tomorrow, and commit as
obvious if successful.

2005-01-22  Tobias Schl"uter  <tobias.schlueter@physik.un-muenchen.de>

        PR fortran/19524
        * io/read.c (read_f): Remove bogus if.

Index: read.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/read.c,v
retrieving revision 1.7
diff -u -p -r1.7 read.c
--- read.c      12 Jan 2005 21:27:31 -0000      1.7
+++ read.c      22 Jan 2005 00:32:45 -0000
@@ -600,8 +600,6 @@ read_f (fnode * f, char *dest, int lengt

  bad_float:
   generate_error (ERROR_READ_VALUE, "Bad value during floating point read");
-  if (buffer != scratch)
-     free_mem (buffer);
   return;

   /* At this point the start of an exponent has been found */


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-22 00:36:12
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]