This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug other/15000] Support setting the default symbol visibility for ELF


------- Additional Comments From bryner at brianryner dot com  2004-04-22 18:35 -------
(In reply to comment #16)
Is 
> your new patch and its use of the type decl instead of the class stack to store 
> visibility a better solution here? I would have thought it makes things unclear 
> for GCC maintainers as the symbol visibility is no longer stored with the symbol 
> but rather with that symbol's type info which might cause some to get confused 
> with the type info's visibility rather than that of which it describes?

I think the reasoning is just that we already have an appropriate place to store
this information, so why invent something new.  Note that the attribute stored
on the type decl is basically used the same way that DECL_VISIBILITYSPECIFIED is
in your patch.  DECL_VISIBILITY is still used for determining the actual
visibility of a symbol.  Also, the 'overrides' thing requires a linear search of
the overrides list every time you assign symbol visibility, so why not just do a
linear search of the attributes list of the decl instead.  There's something to
be said for simplicity as well, and the second patch is certainly much shorter
than the original.

Could you please elaborate on your changes related to inline and virtual functions?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15000


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]