This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug bootstrap/14893] [3.5 Regression] 3.4.0-20040406, 'make install' fails on doc/gcjh.1
- From: "aoliva at gcc dot gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: 15 Apr 2004 05:10:33 -0000
- Subject: [Bug bootstrap/14893] [3.5 Regression] 3.4.0-20040406, 'make install' fails on doc/gcjh.1
- References: <20040408175851.14893.mec.gnu@mindspring.com>
- Reply-to: gcc-bugzilla at gcc dot gnu dot org
------- Additional Comments From aoliva at gcc dot gnu dot org 2004-04-15 05:10 -------
Yeah, this is ok for mainline.
Putting on my paranoid Makefile writer hat, I'd recommend adding an `else :'
between if/fi, just because some shells carry over the exit status of the if
test command to the whole if command, and, if that turns out to be a failure and
we're in `set -e' mode, which Makefile generally enbles, the whole thing falls
apart. I don't quite recall whether shells with this behavior are common, but I
do remember they exist (I'd guess Ultrix if I had to). I'm not sure we care
about it at this point, but there are several such constructs in the gcc
Makefiles, so perhaps we should stick to it.
Sorry that I forgot about it in my previous posting.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14893