[Bug c++/13005] Pointer wrongly adjusted for derived class containing virtual function

["stephenma at telus dot net" <gcc-bugzilla at gcc dot gnu dot org>]

------- Additional Comments From stephenma at telus dot net  2004-01-09 01:33 -------
Falk Hueffner wrote:

> +      warning ("casting from/to an incomplete type is risky; see
-Wno-cast-incomplete");
> Lines must not be longer than 78 characters.

Heh, I knew somebody would mention this.  I went from short to long lines for
readability: several other lines in that file (gcc/cp/typeck.c) are much longer
than 100 characters.


> Also leave out the "see", we don't do that for any other warning.

I think the reference is necessary, because the reason for the warning is rather
subtle.  The intent is to point the programmer to the documentation for
-Wno-cast-incomplete, which is extensive.


> +class Beta;        *b;   // Incomplete class
>
> Spurious ;.

Thanks for catching that typo in the documentation.  I will take this
opportunity to reword a few other things too.


> The changelog lacks file references.

I thought "cvs diff" and "cvs annotate" would make that requirement obsolete,
but OK.


> Also, you need test cases (http://gcc.gnu.org/codingconventions.html).

Ugh.  OK.


> If you have that, I suggest you post your patch to gcc-patches.

Thanks for looking at the patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13005