Re: Preprocessor: some dollars-in-identifiers mishap broke cris-axis-elf

[Neil Booth <neil at daikokuya dot co dot uk>]

Hans-Peter Nilsson wrote:-

> The only refinement useful here is "never".  Again, this was an
> *internal definition* caused by a target macro unrelated to the
> C language and actually unrelated to DOLLARS_IN_IDENTIFIERS.

I disagree - we still want it with -pedantic whether it's an
internal macro or not.

I *really* dislike the idea of conditionalizing our warnings on
what macro some token came from.

> Nope, I'll come up with something different, perhaps for
> __REGISTER_PREFIX__ only.
> 
> For the record (I checked the code), preprocessing asm (which
> this *isn't really* about) will not get a dollar-warning, since
> ->dollars_in_ident is then 0.

Of course, but asm isn't C, asm has legitimate non-identifier
uses of '$'.  C doesn't.

Neil.