This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: 3.0 bogus file information in debugging output
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: "gcc-bugs at gcc dot gnu dot org" <gcc-bugs at gcc dot gnu dot org>, "neil at daikokuya dot demon dot co dot uk" <neil at daikokuya dot demon dot co dot uk>, law at redhat dot com
- Date: Wed, 30 Jan 2002 13:57:35 -0800
- Subject: Re: 3.0 bogus file information in debugging output
> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg01082.html
> (Jason's patch to deal with a change of filename in the middle
> of a function)
This patch is safe and can be applied to the 3.0 branch. Would you
like to do that?
>
> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00278.html
> (Jeff Law's patch to get line numbers correct in multi-line
> conditionals)
This patch isn't quite right from a coding-standards point of view;
there's no comment for c_finish_while_stmt_cond. I'm sure Jeff's
going to fix that. :-)
I also don't see much point in using the first person in comments in
GCC; we'll never know who's talking a little later. So, why write:
"I am not very familiar with this code..."? We should just say "Perhaps
this code could be merged with ..., but that is not clear."
The guts of the patch are OK, though, and we might as well apply it
to the branch, even if it's present form. Would you like to do that
too?
Thanks,
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com