This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: libstdc++/3720: Problems with num_get
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Philip Martin <pmartin at uklinux dot net>
- Cc: bkoz at gcc dot gnu dot org, gcc-bugs at gcc dot gnu dot org, gcc-gnats at gcc dot gnu dot org, gcc-prs at gcc dot gnu dot org, schmid at snake dot iap dot physik dot tu-darmstadt dot de
- Date: Fri, 7 Dec 2001 16:20:02 -0800 (PST)
- Subject: Re: libstdc++/3720: Problems with num_get
> 1. Looking at the code, there are two calls to log() per integer
> input in _M_extract_int() in locale_facets.tcc
OK this is bogus, agreed. Can this stuff be moved into __num_base and be
made const?
> 2. You aren't calling test13() from main() in
> testsuite/27_io/istream_extractor_arith.cc
Ugh.
> 3. Trying the code, input of std::numeric_limits<T>::max() in octal or
> hex doesn't appear to work for integers, e.g. reading 017777777777
> into a long on x86 doesn't work, it appears to accept one character
> too few. Decimal works.
Hmm. I'll look at this, thanks.
I'd like to use some kind of limiting factor for _M_extract_float, like
_M_extract_int has now.
Any thoughts on that? I was kind of hoping that part could wait a bit, but
if anybody's feeling up to it, I'd be psyched.
-benjamin