This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: minor corrections to gthr-dce.h
- To: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- Subject: Re: PATCH: minor corrections to gthr-dce.h
- From: law at redhat dot com
- Date: Tue, 15 May 2001 18:14:11 -0700
- cc: gcc-bugs at gcc dot gnu dot org
- Reply-To: law at redhat dot com
In message <200105160056.UAA04956@hiauly1.hia.nrc.ca>you write:
> The following patch fixes a number of compilation warnings about unused
> arguments and the missing declaration for pthread_key_delete under hpux 10.
> 20.
>
> I am not sufficiently versed in dce thread implementations to know whether
> the library check is suitable for all systems to determine whether or not
> pthread_key_delete is available. I know it will work for hpux 10 and 11.
> Possibly, a configure check is needed.
>
> Testing is rather limited at the moment. I know that libgcc builds ok and
> that the UNUSED macro works with C++ code.
>
> Dave
> --
> J. David Anglin dave.anglin@nrc.ca
> National Research Council of Canada (613) 990-0752 (FAX: 952-6
> 605)
>
> 2001-05-15 John David Anglin <dave@hiauly1.hia.nrc.ca>
>
> * gthr-dce.h (UNUSED): Attribute unused macro.
> (__gthread_key_dtor): Make arguments UNUSED.
> (__gthread_key_delete): Revise for compatibility with DRAFT4
> implementation.
Based on your comments, this patch is not critical for the GCC 3 release,
correct?
If so, then go ahead and install it into the mainline sources. If it is
critical for the GCC 3 release, then we'll need to review/test it in more
detail.
jeff