Re: Problem with stack-adjustment code

[Richard Henderson <rth at cygnus dot com>]

On Sat, Apr 29, 2000 at 12:57:05AM +0200, Jan Hubicka wrote:
> BTW the calls.c seems to be big trouble currently. I would like to know
> your opinion about my patches.  On the one hand I am trying to cleanup
> the design on the other hand I am causing breakage here and there.  Do
> you think my attempts are worts that?

I believe that cleaning up calls.c is still a worthy cause.  We just
need to be more careful in the writing and reviewing.  And make the
changes as small as possible.

> BTW2 my plans about the whole stack alignment issue whas to redesign
> it basically to do the alignment and neccesary calculation right before
> the first push instruction is emitted (called from store_one_arg

I'll remain agnostic to this, not having thought it all the way through.
If it reduces the number of places we have to care about this mess then
it's probably a good thing.

> ... but it needed quite large changes to expand_call and emit_library_call
> so I've delayed this issue before the merger complettes.

It's probably the case that merging expand_call and emit_library_call
is the cleanup with the biggest payoff in that code currently.  If we're
to do more changing in this code, lets tackle that one first, so that
we can make the other desired cleanups in one place instead of two.



r~