This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
bogus fixes
- To: Bruce Korb <bkorb at gnu dot org>
- Subject: bogus fixes
- From: Philipp Thomas <pthomas at suse dot de>
- Date: Fri, 31 Mar 2000 03:07:45 +0200
- Cc: gcc-bugs at gcc dot gnu dot org
Bruce,
fixinclude does bogus fixes, at least on my Linux glibc2 system.
/usr/include/net/bpf.h has this code:
/*
* BPF ioctls
*
* The first set is for compatibility with Sun's pcc style
* header files. If your using gcc, we assume that you
* have run fixincludes so the latter set should work.
*/
#if (defined(sun) || defined(ibm032)) && !defined(__GNUC__)
#define BIOCGBLEN _IOR(B,102, u_int)
So the header *has* checks for __GNUC__ and defines ioctls with proper
quoting if gcc compiles it. Still fixincludes produces a header which also
changes this conditionalized block, which IMO is a bug.
The other bogus fix is done for /usr/include/rpc/svc.h, where it 'fixes'
prototypes *in comments*.
Philipp
--
Philipp Thomas <pthomas@suse.de>
SuSE GmbH, Schanzaecker Str. 10, D-90443 Nuremberg, Germany
#define NINODE 50 /* number of in core inodes */
#define NPROC 30 /* max number of processes */
-- Version 7 UNIX fuer PDP 11, /usr/include/sys/param.h