gcc 2-95.2 installation : gas,Solarisx86

[Mario Obejas <obejas at phylum dot rsc dot raytheon dot com>]

I believe I have rediscovered a gcc-2.95.2 bug that was reported on a 
previousl release by Alexandre Oliva  <oliva@lsd.ic.unicamp.br>
but the implemented fix was incomplete. It appears that variables
introduced to fix the problem are not checked.

Background
  Solaris i386: I found that the system insisted on sending a "-s" to as, which 
is not compatible with gnu as (aka gas). 
  
I found this buried in gcc/ChangeLog:
Wed Sep 22 07:07:44 1999  Alexandre Oliva  <oliva@lsd.ic.unicamp.br>

        * config/i386/sol2.h (PREFERRED_DEBUGGING_TYPE): Use stabs.
        (ASM_SPEC): Moved from sol2dbg.h.  Added work-around for gas.
        * config/i386/sol2dbg.h: Removed.
        * config/i386/sol2gas.h: New file, to enable gas work-around.
        * configure.in: Use i386/sol2gas.h on Solaris/x86 --with-gas.
        Don't use sol2dbg.h.
        * configure: Rebuilt.

Solution: Two fixes accomplish the intended fix.
1. in gcc/configure
   Explanation:
     "with_gas" variable is set but is not used. "gas" is used instead
      --gas is declared an "obsolete" expression
   Fix: Use "with_gas" variable as intended
     At line 3753, where the "i[34567]86-*-solaris2*" case is checked:
                #! (Mario Obejas) I found a bug!!!
                #if test x$gas = xyes; then
                if test x$with_gas = xyes; then
                
2. in gcc/config/i386/sol2gas.h
   Explanation:
     GAS_REJECTS_MINUS_S is used by sol2.h,
     but sol2gas.h sets GAS_DOES_NOT_SUPPORT_MINUS_S  instead.
   Fix: 
     Use either GAS_REJECTS_MINUS_S OR GAS_DOES_NOT_SUPPORT_MINUS_S
     but be consistent about which one is used 
     in both sol2gas.h and sol2.h
     My fix was to add in sol2gas.h:
/* What the real fix should be (Mario Obejas) */
#ifndef GAS_REJECTS_MINUS_S
#define GAS_REJECTS_MINUS_S 1
#endif

My configure values:
./configure --with-gas --prefix=/home/gcc_2.95
My system uname -a:
SunOS ash 5.7 Generic_106542-08 i86pc i386 i86pc

If this bug report can get me (Mario Obejas, obejas@phylum.rsc.raytheon.com)
immortalized in the Changelog, you'll make my day.

Thanks and keep up the great work you folks represent.
-Mario