Re: bootstrap problem: i386-pc-solaris-2.7, using GNU as

[Alexandre Oliva <oliva at lsd dot ic dot unicamp dot br>]

On Oct 28, 1999, "Beardsley, Jason" <jbeardsley@origin.ea.com> wrote:

> I found a minor problem building gcc-2.95.2 on this platform, traced it down
> to a typo in gcc/config/i386/sol2gas.h.  It defines the symbol
> GAS_DOES_NOT_SUPPORT_MINUS_S, when it I believe it should define
> GAS_REJECTS_MINUS_S (which is what sol2.h checks for).

Gee!  My goof :-(

I must have installed the wrong version of the sol2gas.h patch in the
release branch :-( :-(

Shame on me for having blindly applied the wrong patch I had posted,
instead of the one I applied in the trunk :-(

Here's a patch that fixes the branch for 2.95.3, if it is ever
released.  Ok to install?

Index: gcc/ChangeLog
from  Alexandre Oliva  <oliva@lsd.ic.unicamp.br>
	
	* config/i386/sol2gas.h: I had installed the wrong version of Sept
	22's patch in the release branch.  Fixed.
	* configure.in: Likewise.
	* configure: Rebuilt.
	Reported by Jason Beardsley <jbeardsley@origin.ea.com>
	
Index: gcc/configure.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/configure.in,v
retrieving revision 1.246.4.12
diff -u -r1.246.4.12 configure.in
--- gcc/configure.in	1999/10/13 07:58:02	1.246.4.12
+++ gcc/configure.in	1999/10/28 23:05:38
@@ -1399,11 +1399,10 @@
 changequote([,])dnl
 		xm_file="xm-siglist.h xm-alloca.h ${xm_file}"
 		xm_defines="USG POSIX SMALL_ARG_MAX"
+		tm_file=i386/sol2.h
 		if test x$gas = xyes; then
 			# Only needed if gas does not support -s
-			tm_file=i386/sol2gas.h
-		else
-			tm_file=i386/sol2.h
+			tm_file="i386/sol2gas.h ${tm_file}"
 		fi
 		tmake_file=i386/t-sol2
 		extra_parts="crt1.o crti.o crtn.o gcrt1.o gmon.o crtbegin.o crtend.o"
Index: gcc/config/i386/sol2gas.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/i386/sol2gas.h,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 sol2gas.h
--- gcc/config/i386/sol2gas.h	1999/09/22 10:44:21	1.1.2.1
+++ gcc/config/i386/sol2gas.h	1999/10/28 23:05:38
@@ -4,8 +4,6 @@
    Copyright (C) 1999 Free Software Foundation, Inc.
 */
 
-#ifndef GAS_DOES_NOT_SUPPORT_MINUS_S
-#define GAS_DOES_NOT_SUPPORT_MINUS_S 1
+#ifndef GAS_REJECTS_MINUS_S
+#define GAS_REJECTS_MINUS_S 1
 #endif
-
-#include "i386/sol2.h"

Here's a patch for `gcc/configure', just in case someone who needs
this patch doesn't have `autoconf' handy:

Index: gcc/configure
===================================================================
RCS file: /cvs/gcc/egcs/gcc/configure,v
retrieving revision 1.242.4.12
diff -u -r1.242.4.12 configure
--- gcc/configure	1999/10/13 07:58:02	1.242.4.12
+++ gcc/configure	1999/10/28 23:10:32
@@ -3750,11 +3750,11 @@
 	i[34567]86-*-solaris2*)
 		xm_file="xm-siglist.h xm-alloca.h ${xm_file}"
 		xm_defines="USG POSIX SMALL_ARG_MAX"
+		tm_file=i386/sol2.h
 		if test x$gas = xyes; then
 			# Only needed if gas does not support -s
-			tm_file=i386/sol2gas.h
-		else
-			tm_file=i386/sol2.h
+			tm_file="i386/sol2gas.h ${tm_file}"
+			#
 		fi
 		tmake_file=i386/t-sol2
 		extra_parts="crt1.o crti.o crtn.o gcrt1.o gmon.o crtbegin.o crtend.o"

And here's a patch for the platform-specific installation
instructions.  Ok to install?  (x86-sol2-gas.patch is a single file
containing both of the patches above)

Index: install/specific.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/install/specific.html,v
retrieving revision 1.52
diff -u -r1.52 specific.html
--- install/specific.html	1999/10/17 02:12:51	1.52
+++ install/specific.html	1999/10/28 23:21:05
@@ -17,6 +17,7 @@
   <li><a href="#hppa*-hp-hpux10">hppa*-hp-hpux10</a></li>
   <li><a href="#ix86-*-linux*">i?86-*-linux*</a></li>
   <li><a href="#ix86-*-sco3.2v5*">i?86-*-sco3.2v5*</a></li>
+  <li><a href="#ix86-*-solaris*">i?86-*-solaris*</a></li>
   <li><a href="#ix86-*-udk">i?86-*-udk</a></li>
   <li><a href="#*-ibm-aix*">*-ibm-aix*</a></li>
   <li><a href="#m68k-*-nextstep*">m68k-*-nextstep*</a></li>
@@ -256,6 +257,16 @@
 backtrace with a fault occurring in <code>rtld()</code> and the program
 running as <code>/usr/lib/ld.so.1</code>.  This problem has been reported to SCO engineering
 and will hopefully be addressed in later releases.</p>
+
+
+<hr>
+<h3><a name="ix86-*-solaris*">i?86-*-solaris*</a></h3>
+
+<p>GCC 2.95.2, when configured to use the GNU assembler, would invoke
+it with the <code>-s</code> switch, that GNU as up to 2.9.5.0.12 does
+not support.  If you'd rather not use a newer GNU as nor the native
+assembler, you'll need the patch <a
+href="x86-sol2-gas.patch"><code>`x86-sol2-gas.patch'</code></a>.</p>
 
 
 <hr>


Guys, sorry about this :-(

-- 
Alexandre Oliva http://www.ic.unicamp.br/~oliva IC-Unicamp, Bra[sz]il
oliva@{lsd.ic.unicamp.br,guarana.{org,com}} aoliva@{acm,computer}.org
oliva@{gnu.org,kaffe.org,{egcs,sourceware}.cygnus.com,samba.org}
** I may forward mail about projects to mailing lists; please use them