This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Another problem: initializer_constant_valid_p
- To: kenner at vlsi1 dot ultra dot nyu dot edu
- Subject: Another problem: initializer_constant_valid_p
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Sun, 31 Oct 1999 19:58:22 -0800
- Cc: gcc-bugs at gcc dot gnu dot org
- Reply-to: mark at codesourcery dot com
In the Chill subdirectory, we get:
../varasm.o: In function `initializer_constant_valid_p':
/home/mitchell/dev/egcs/objdir/gcc/../../gcc/varasm.c:4028: multiple definition of `initializer_constant_valid_p'
typeck.o:/home/mitchell/dev/egcs/objdir/gcc/ch/../../../gcc/ch/typeck.c:3685: first defined here
due to this change:
Thu Oct 28 18:06:50 1999 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
* c-common.h (initializer_constant_valid_p): Delete decl from here.
* output.h (initializer_constant_valid_p): Move decl to here.
* c-common.c (initializer_constant_valid_p): Delete function from here.
* varasm.c (initializer_constant_valid_p): Move function to here.
It's good to remove duplicate code. Perhaps you meant to remove this
code from ch/typeck.c as well? The version there, however, is subtly
different from the version now in varasm.c. Perhaps due to skew over
time; perhaps intentionally. This needs to be resolved.
A full bootstrap would have revealed this problem; the informal policy
is that any significant change requires a full bootstrap/make check
sequence before checkin.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com