This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: C++ Patch (Was: Virtual Mem Func Ptr Call Fails When BaseClass Has No Vtable)
- To: martin at mira dot isdn dot cs dot tu-berlin dot de
- Subject: Re: C++ Patch (Was: Virtual Mem Func Ptr Call Fails When BaseClass Has No Vtable)
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Wed, 15 Sep 1999 07:44:10 -0700
- Cc: mrs at wrs dot com, gcc-patches at gcc dot gnu dot org, oliva at lsd dot ic dot unicamp dot br, andrew dot bell at bigfoot dot com, bug-gcc at gcc dot gnu dot org
- Organization: CodeSourcery, LLC
- References: <199909150014.RAA17491@kankakee.wrs.com><199909150805.KAA22191@mira.isdn.cs.tu-berlin.de>
>> Yes, sounds like the right fix to me. Please do up the fix and
>> submit it.
Martin> Attached below. Because of re-indentation, it looks larger
Martin> than it actually is.
This is fine.
! /* This used avoid checking for virtual functions if basetype
! has no virtual functions, according to an earlier ANSI draft.
! With the final ISO C++ rules, such an optimization is
! incorrect. */
Say `used to'; just `used' is ungrammatical. And one more sentence
explaining that a virtual function in the derived class can be called
with a pointer to member of the base class wouldn't hurt.
Thanks!
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com