This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Bogus comment in rtl.h?



  In message <199902041946.LAA01368@markmitchell.com>you write:
  > 
  > Would someone who knows what's going on care to fix the following
  > discrepancy?  There's a comment in rtl.h which says:
  > 
  >   /* 1 in an INSN if it can alter flow of control
  >      within this function.  Not yet used!  */
  >   unsigned int jump : 1;
  >   /* 1 in an INSN if it can call another function.  Not yet used!  */
  >   unsigned int call : 1;
  > 
  > But, later we have:
  > 
  >   #define LINK_COST_ZERO(X) ((X)->jump)
  >   #define LINK_COST_FREE(X) ((X)->call)
  > 
  > Are these macros actively used?  If so, shouldn't the `Not yet used!'
  > be stricken?
  > 
  > Thanks in advance to whatever noble soul is willing to fix this
  > documentation buglet.
I think the "not yet used yet" needs to disappear and be replaced by 
an appropriate comment based on the uses by the scheduler.

Thanks for pointing this out! -- I'd been using them for some stuff I've been
working on (sibcalls) on the assumeption that they were still unused.

My use of those bits may not actually be safe...


jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]