This is the mail archive of the
mailing list for the GCC project.
Re: : Warning patches #1/5 - signed vs. unsigned.
- To: manfred at s-direktnet dot de, wilson at cygnus dot com
- Subject: Re: : Warning patches #1/5 - signed vs. unsigned.
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Wed, 11 Mar 1998 19:48:51 -0500 (EST)
- Cc: Manfred dot Hollstein at ks dot sel dot alcatel dot de, egcs-bugs at cygnus dot com
> From: Jim Wilson <firstname.lastname@example.org>
> This is OK to install.
> I see that you have an enquire.c change. The enquire.c copyright requires
> that we document all changes near the top of the file. Please add such a
> change similar to the existing changes.
> In dwarf2out.c (reg_save) I added a FIXME comment to highlight a
> comparison of an unsigned variable with -1 in an if statement!
> ! if (sreg == -1) /* FIXME: How can this be -1? It is an unsigned! */
> Can someone who's more experienced with this particular code take a look?
> The code is correct. -1 is used to indicate that the value isn't a register
> number. The -1 just gets casted to unsigned, and becomes UINT_MAX. It may
> not be pretty, but I think it should always work.
In that case, when Manfred checks it in, the -1 should be
explicitly cast to unsigned (to silence the warning) with a comment
stuck on top of it (eg, your words above.) Yes?
Kaveh R. Ghazi Project Manager / Custom Development
email@example.com Icon CMT Corp.