This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: [980307]: Warning patches #3/5 - Unused variables, functions, etc.
- To: egcs-bugs at cygnus dot com, manfred at s-direktnet dot de
- Subject: Re: [980307]: Warning patches #3/5 - Unused variables, functions, etc.
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Mon, 9 Mar 1998 11:59:25 -0500 (EST)
- Cc: Manfred dot Hollstein at ks dot sel dot alcatel dot de, law at cygnus dot com
> From: Manfred Hollstein <manfred@s-direktnet.de>
>
> Sun Mar 8 17:06:02 1998 Manfred Hollstein <manfred@s-direktnet.de>
>
> * genattr.c (fatal): Add explicit definition of int parameters.
> * genconfig.c (fatal): Likewise.
> * genemit.c (fatal): Likewise.
> * genextract.c (fatal): Likewise.
> * genflags.c (fatal): Likewise.
> * genopinit.c (fatal): Likewise.
> * genoutput.c (fatal): Likewise.
> * genpeep.c (fatal): Likewise.
Thanks for the warning fix contributions!
One issue, this change perpetuates the hack wherein variable
arguments are faked using ints.
I floated the idea of using a replacement macro for the fatal
function which didn't take off. An alternate solution is to make fatal
an actual stdarg/varargs function using the same portability tricks in
cccp.c and toplev.c.
I'm going to be working on generalizing variable argument stuff
into system.h and converting `fatal' in gen*.c (after I finish converting
the rest of the source to use system.h.) Can we hold off on this part of
your patch until I get to that?
Thanks,
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu ICon CMT Corp.