This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] PR39239 EQUIVALENCE and BIND(C)
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Nicolas Koenig <koenigni at student dot ethz dot ch>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 20 Mar 2017 09:35:10 +0000
- Subject: Re: [Patch, fortran] PR39239 EQUIVALENCE and BIND(C)
- Authentication-results: sourceware.org; auth=none
- References: <a1f779fc-0e8a-70be-5e2f-f05d47f5b2bc@student.ethz.ch> <CAGkQGiL7Om8dOLAU=wjDZXCDg6CNT7-LFDmvyuj1jZaDHOH0Ng@mail.gmail.com> <06176ef6-0a55-bb29-3ee9-f76698843389@student.ethz.ch>
Dear Nicolas,
This is OK for trunk.
Thanks for the patch.
Paul
On 19 March 2017 at 14:34, Nicolas Koenig <koenigni@student.ethz.ch> wrote:
> Hello Paul,
>
> there isn't really a reason for that except for not knowing where to put the
> error. Attached are the new patch & test case.
>
> The paperwork is done and I have commit rights.
>
> Thanks for the kind welcome!
>
> Nicolas
>
> Regression tested for x86_64-pc-linux-gnu.
>
> 2017-03-12 Nicolas Koenig <koenigni@student.ethz.ch>
>
> PR fortran/39239
> * symbol.c (check_conflict): report an error if an EQUIVALENCE variable
> is BIND(C).
>
> 2017-03-12 Nicolas Koenig <koenigni@student.ethz.ch>
>
> PR fortran/39239
> * gfortran.dg/equiv_constraint_bind_c.f90: New test.
>
>
> On 03/19/2017 01:02 PM, Paul Richard Thomas wrote:
>>
>> Hi Nicolas,
>>
>> Is there some reason that you didn't use symbol.c(check_conflict)? The
>> conflict check could be added at line 547. If this results in
>> repetitions of the error message, then your patch is OK. Otherwise, I
>> would pop it in there.
>>
>> Do you have commit rights? ie. have you done the FSF paperwork?
>>
>> Welcome aboard!
>>
>> Paul
>>
>> On 19 March 2017 at 00:15, Nicolas Koenig <koenigni@student.ethz.ch>
>> wrote:
>>>
>>> Hello everyone,
>>>
>>> I submitted this patch a week ago, but I think it got lost. It adds an
>>> error
>>> if BIND(C) is used with EQUIVALENCE.
>>>
>>> Nicolas
>>>
>>> Regression tested for x86_64-pc-linux-gnu.
>>>
>>> 2017-03-18 Nicolas Koenig <koenigni@student.ethz.ch>
>>>
>>> PR fortran/39239
>>> * resolve.c (resolve_equivalence): report an error if an
>>> equivalence variable is BIND(C).
>>>
>>> 2017-03-18 Nicolas Koenig <koenigni@student.ethz.ch>
>>>
>>> PR fortran/39239
>>> * gfortran.dg/equiv_constraint_bind_c.f90: New test.
>>>
>>
>>
>
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein