This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fortran: remove trailing exclamation mark from various diagnostics (PR fortran/79852)


On 03/14/2017 10:47 PM, Steve Kargl wrote:
> On Tue, Mar 14, 2017 at 08:35:50PM -0700, Jerry DeLisle wrote:
>> On 03/14/2017 06:01 PM, David Malcolm wrote:
>>> PR fortran/79852 reports various Fortran diagnostics that have a trailing
>>> exclamation mark in their messages.
>>>
>>> Is there a Fortran-specific convention here?
>>>
>>
>> No reason at all.
> 
> One occurs in a gfc_internal_error() and if we hit that then
> there is a MAJOR fly in the ointment.  An exclamation is
> probably appropriate;  Oh, and I have triggered that very
> error.  Another appears in a gcc_fatal_error().  If a user
> hits that, then an exclamation is merited in that the user's
> code is so poorly written one can only exclaim.
> 

maybe instead of exclamation point we should do

...., are you serious?

;)

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]