This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 21 Nov 2015 10:07:35 -0800
- Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
- Authentication-results: sourceware.org; auth=none
- References: <20151120005836 dot GA53763 at troutmask dot apl dot washington dot edu> <20151120200947 dot GA61350 at troutmask dot apl dot washington dot edu> <CAGkQGi+bvMEzo_xk_=Ugu5GdrtV28peFvOQHnAAqAUoSTJaVxw at mail dot gmail dot com> <20151121162657 dot GA23304 at troutmask dot apl dot washington dot edu>
On Sat, Nov 21, 2015 at 8:26 AM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Sat, Nov 21, 2015 at 11:41:51AM +0100, Paul Richard Thomas wrote:
>>
>> Just a couple of small typos:
>> "Unexpected expr_type cause an ICE" ; causes?
>> "! An array of derived types workd too." ; works?
>>
>> Apart from that it's OK for trunk.
>>
>> Thanks for the patch
>>
>
> Thanks for the the review. I don't have a clue as
> to how to do simplification for rank > 2. :(
>
It breaks bootstrap:
int dm;
/* DIM is only useful for rank > 1, but deal with it here as one can
set DIM = 1 for rank = 1. */
if (dim)
{
if (!gfc_is_constant_expr (dim))
return NULL;
dm = mpz_get_si (dim->value.integer);
}
else
dm = 1;
dm is set, but never used.
H.J.