This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: *ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Mikael Morin <mikael dot morin at sfr dot fr>
- Cc: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>, Andre Vehreschild <vehre at gmx dot de>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 16 May 2015 10:13:35 +0200
- Subject: Re: *ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiKfuxfsnHuwGnsk5R7f=bOu3OzvxtZweL0cGzMmHDGAkQ at mail dot gmail dot com> <20150426185319 dot GA29878 at troutmask dot apl dot washington dot edu> <CAGkQGiK0puVoALMW36TzdoWPE=zw8fNOEu2uzeAEO6CJe2SUoA at mail dot gmail dot com> <CAGkQGiK442R2=p=m-gHHkK=cZKvyUT5QvAiGMbEjCP2gieeOLA at mail dot gmail dot com> <554E07CA dot 2020808 at sfr dot fr> <55562656 dot 7040304 at sfr dot fr>
Dear Mikael,
With your tweak it bootstrapped and regtested OK. Also changed the
comment after Steve's pointing out that the last sentence was
incomprehensible:-)
Committed to trunk as revision 223234.
Cheers
Paul
2015-05-16 Mikael Morin <mikael@gcc.gnu.org
Paul Thomas <pault@gcc.gnu.org>
PR fortran/65792
* trans-expr.c (gfc_trans_subcomponent_assign): Always assign
the expression component to the destination. In addition, if
the component has allocatable components, copy them and
deallocate those of the expression, if it is not a variable.
The expression is fixed if not a variable to prevent multiple
evaluations.
2015-05-16 Mikael Morin <mikael@gcc.gnu.org>
PR fortran/65792
* gfortran.dg/derived_constructor_components_5: New test
On 15 May 2015 at 19:01, Mikael Morin <mikael.morin@sfr.fr> wrote:
> Le 09/05/2015 15:12, Mikael Morin a écrit :
>> Le 01/05/2015 20:25, Paul Richard Thomas a écrit :
>>> Dear All,
>>>
>>> By the time I went to commit, something had changed and the patch
>>> caused a regression. I presume that the version that I had of Andre's
>>> patch was not the same as the one committed. I'll cast an eye over it
>>> this weekend and see if I can understand what gives.
>>>
>> Hello Paul,
>>
>> to get things moving again, I propose the attached fix to your patch.
>> Tested on alloc_comp_deep_copy_1 only for now.
>
> Hello Paul,
>
> any news?
>
> Mikael
--
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.
Groucho Marx