This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR62044 ICE when loading use-renamed extended derived type

From: Tobias Burnus <burnus at net-b dot de>
To: Mikael Morin <mikael dot morin at sfr dot fr>, gcc-patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
Date: Sun, 25 Jan 2015 16:06:11 +0100
Subject: Re: [Patch, fortran] PR62044 ICE when loading use-renamed extended derived type
Authentication-results: sourceware.org; auth=none
References: <54C50265 dot 8000104 at sfr dot fr>

Mikael Morin wrote:

I have had a look at PR62044 where the compiler ICEs when loading the
extensions of a derived type from a module file, because one use-renamed
extended type is not found under its original name.

After scratching my head on the tree of extended types (rooted at
derived->f2k_derived->sym_root), wondering whether the renamed or
original name should be used, I decided to remove all that nonsense.

So here is the patch, regression tested on x86_64-unknown-linux-gnu.
There is a failure, graphite/pr42393.f90, also present on mainline.
OK for trunk/4.9/4.8 ?

Regarding the failure: The reason of the failure is the GCC 5 change forGraphite from CLooG (using ISL) to ISL (used directly) and a bug in ISL0.12.2. The solution is to update to ISL 0.14.0 - or to ignore thefailure. See also PR64017.

Regarding the patch: It looks fine to me â and as I assume/hope that thetest suite is comprehensive, it shouldn't break something obvious.


Hence, OK from my side. Thanks for the patch!

Tobias

References:
- [Patch, fortran] PR62044 ICE when loading use-renamed extended derived type
  - From: Mikael Morin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]