This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran, OOP] PR 60922: [4.9/5 regression] Memory leak with allocatable CLASS components
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Tobias Burnus <burnus at net-b dot de>
- Date: Fri, 23 Jan 2015 09:33:33 +0100
- Subject: Re: [Patch, Fortran, OOP] PR 60922: [4.9/5 regression] Memory leak with allocatable CLASS components
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qjQzp3qDaA=Y62KiL2Ed_As5bz9AKu+Cd69hLAMahdDJw at mail dot gmail dot com> <CAKwh3qifZ6QKj5DK0LGh=xUxkvDKhzzM_q8ioamhuPko7p3oEg at mail dot gmail dot com> <CAGkQGi+eFBwMhk4hhrFiERzH9Z55=tP8Zd5ja+X1iG3eker2KQ at mail dot gmail dot com>
2015-01-22 17:38 GMT+01:00 Paul Richard Thomas <paul.richard.thomas@gmail.com>:
> As it happens I loaded this patch up last night to see if I could plug
> the last leak in my patch for PR63205, which is making heavy use of
> the default finalizers. It seemed to do the job. As you said in the PR
> it appears to be a typo and really is obvious. I can canfirm that it
> bootstraps and regtests OK.
>
> Good for 4.9 and 5.0
Committed to trunk as r220029. Will backport to 4.9 on the weekend.
Thanks for reviewing!
Cheers,
Janus
> On 22 January 2015 at 16:37, Janus Weil <janus@gcc.gnu.org> wrote:
>> Ping!
>>
>>
>>
>> 2015-01-18 11:46 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
>>> Hi all,
>>>
>>> the attached patch is close to trivial and fixes a memory-leak
>>> regression that appeared after the implementation of finalization.
>>>
>>> My suspicion it that it's simply a copy'n'paste error, where the wrong
>>> attribute was copied from very similar code a few lines above, but I'd
>>> like to have that confirmed by the original author (which should be
>>> Tobias).
>>>
>>> Regtested on x86_64-unknown-linux-gnu. Ok for trunk and 4.9?
>>>
>>> Cheers,
>>> Janus
>>>
>>>
>>> 2015-01-18 Janus Weil <janus@gcc.gnu.org>
>>>
>>> PR fortran/60922
>>> * class.c (finalize_component): Apply the check for 'fini_coarray' only
>>> to coarray components.
>>>
>>> 2015-01-18 Janus Weil <janus@gcc.gnu.org>
>>>
>>> PR fortran/60922
>>> * gfortran.dg/class_allocate_17.f90: Extended.
>
>
>
> --
> Outside of a dog, a book is a man's best friend. Inside of a dog it's
> too dark to read.
>
> Groucho Marx