This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran] Better error messages for type/rank checks
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Manfred Schwarb <manfred99 at gmx dot ch>
- Cc: Janne Blomqvist <blomqvist dot janne at gmail dot com>, Tobias Burnus <burnus at net-b dot de>, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 31 May 2013 22:30:19 +0200
- Subject: Re: [Patch, Fortran] Better error messages for type/rank checks
- References: <CAKwh3qjTfdWCvA4+jRDiz8WmB6GHJtq1OdOecSrdBw3zUTqxnQ at mail dot gmail dot com> <51A7C4BE dot 9060509 at net-b dot de> <CAKwh3qhH+Z_ydyeFGUaHkvwwb3Je-cbbe=5FkwUDzHu1c4aw7w at mail dot gmail dot com> <51A874BC dot 4070901 at gmx dot ch> <CAKwh3qjFVUbM2QXBMRy09T77DDYP31rd+SpXBAHzADQexUAK-w at mail dot gmail dot com> <CAO9iq9F7oW4G+cWeq3hkN_R+E=JBYpSHeRPo=xje1hSgTmFOTA at mail dot gmail dot com> <CAKwh3qg9z8GE4072uNXW2ua3cpm1NZggAXEf_6GeBmT5K1SR5A at mail dot gmail dot com> <51A8AC45 dot 7000100 at gmx dot ch>
>>> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports
>>> that we're outputting to a terminal?
>>
>>
>> Good point. Updated patch attached, which imposes no limit if we're
>> not outputting to a terminal (as suggested by Mikael).
>>
>> Ok for trunk, or am I missing anything else? (Testing welcome ...)
>>
>
> needs "#include <unistd.h>" for isatty(), perhaps.
I think it is already included (via system.h).
> Otherwise looks sane at first glance.
Thanks for the feedback!
Cheers,
Janus