This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 42418: PROCEDURE: Rejects interface which is both specific and generic procedure


>> The patch was regtested successfully on x86_64-unknown-linux-gnu. Ok for
>> trunk?
>
>
> The patch looks  okay.

Thanks!

> I assume, the patch doesn't help to get PR 54035
> fixed,does it? (That PR is about TBP binding to the generic instead of the
> specific name.)

Not directly. Although - since they're not completely unrelated - one
might think about applying a similar strategy for that one. However, I
expect it will be a bit harder to fix. Maybe I'll have a look soon ...

In general I don't really like the sort of special-case treatment that
is needed, e.g. in this PR, to handle generics and specifics with the
same. In the long run, it might be worth to think about a separate
symtree for generics in each namespace. That would also help to
simplify the treatment of 'constructors' etc, but it's surely not a
quick'n'easy project (and I'm not sure if there are any pitfalls
lurking).

Cheers,
Janus



>> 2012-07-31  Janus Weil  <janus@gcc.gnu.org>
>>
>>         PR fortran/42418
>>         * decl.c (match_procedure_interface): Move some checks to
>>         'resolve_procedure_interface'. Set flavor if appropriate.
>>         * expr.c (gfc_check_pointer_assign): Cleanup of
>> 'gfc_is_intrinsic'.
>>         * intrinsic.c (gfc_is_intrinsic): Additional checks for attributes
>> which
>>         identify a procedure as being non-intrinsic.
>>         * resolve.c (resolve_procedure_interface): Checks moved here from
>>         'match_procedure_interface'. Minor cleanup.
>>         (resolve_formal_arglist,resolve_symbol): Cleanup of
>>         'resolve_procedure_interface'
>>         (resolve_actual_arglist,is_external_proc): Cleanup of
>>         'gfc_is_intrinsic'.
>>
>> 2012-07-31  Janus Weil  <janus@gcc.gnu.org>
>>
>>         PR fortran/42418
>>         * gfortran.dg/proc_decl_29.f90: New.
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]