This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Trim spaces on list-directed reads


Manfred Schwarb wrote:
Am 16.04.2012 23:31, schrieb Thomas Koenig:
Am 16.04.2012 22:32, schrieb Dominique Dhumieres:
I have tested pr50673 and it still takes ~8s at r186501.
Strange, it works for me:

I have to agree with Dominique, I just tested rev.186508, timings for bug 38199 are approximately the same as with GCC 4.7.

Something seems not to work...

I can also reproduce it: The valgrind failure and the long execution time. The following patch fixes both issues.


Thomas & Jerry: What do you think?

Tobias

--- a/libgfortran/io/unit.c
+++ b/libgfortran/io/unit.c
@@ -419,7 +419,7 @@ get_internal_unit (st_parameter_dt *dtp)
     {
       /* If we are not processing an array, adjust the unit record length not
         to include trailing blanks for list-formatted reads.  */
-      if (dtp->u.p.mode == READING&&  dtp->format == NULL)
+      if (dtp->u.p.mode == READING&&  !(dtp->common.flags&  IOPARM_DT_HAS_FORMAT))
        {
          if (dtp->common.unit == 0)
            {





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]