This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] Trim spaces on list-directed reads
- From: Tobias Burnus <burnus at net-b dot de>
- To: Manfred Schwarb <manfred99 at gmx dot ch>
- Cc: Thomas Koenig <tkoenig at netcologne dot de>, Dominique Dhumieres <dominiq at lps dot ens dot fr>, fortran at gcc dot gnu dot org, Jerry DeLisle <jvdelisle2 at gmail dot com>
- Date: Tue, 17 Apr 2012 01:15:27 +0200
- Subject: Re: [patch, fortran] Trim spaces on list-directed reads
- References: <20120416203248.C352D3BE18@mailhost.lps.ens.fr> <4F8C8FC6.1020704@netcologne.de> <4F8C9DC6.700@gmx.ch>
Manfred Schwarb wrote:
Am 16.04.2012 23:31, schrieb Thomas Koenig:
Am 16.04.2012 22:32, schrieb Dominique Dhumieres:
I have tested pr50673 and it still takes ~8s at r186501.
Strange, it works for me:
I have to agree with Dominique, I just tested rev.186508,
timings for bug 38199 are approximately the same as with GCC 4.7.
Something seems not to work...
I can also reproduce it: The valgrind failure and the long execution
time. The following patch fixes both issues.
Thomas & Jerry: What do you think?
Tobias
--- a/libgfortran/io/unit.c
+++ b/libgfortran/io/unit.c
@@ -419,7 +419,7 @@ get_internal_unit (st_parameter_dt *dtp)
{
/* If we are not processing an array, adjust the unit record length not
to include trailing blanks for list-formatted reads. */
- if (dtp->u.p.mode == READING&& dtp->format == NULL)
+ if (dtp->u.p.mode == READING&& !(dtp->common.flags& IOPARM_DT_HAS_FORMAT))
{
if (dtp->common.unit == 0)
{