This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [fortran, patch] Fix display of locus when source contains wide characters
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sun, 4 Mar 2012 14:46:19 +0100
- Subject: Re: [fortran, patch] Fix display of locus when source contains wide characters
- Authentication-results: mr.google.com; spf=pass (google.com: domain of stevenb.gcc@gmail.com designates 10.236.185.42 as permitted sender) smtp.mail=stevenb.gcc@gmail.com; dkim=pass header.i=stevenb.gcc@gmail.com
- References: <E2EDC251-E6A2-4C3D-9BC9-CE690CF5A2DD@gmail.com>
On Sat, Mar 3, 2012 at 4:08 PM, FX <fxcoudert@gmail.com> wrote:
> The attached patch fixes PR 36160 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36160). It should correctly account for wide characters when display error loci. I'm not sure if we can check that in the testsuite harness, but you can manually see it at work on the attached test.f90.
>
> Bootstrapped and regtested on x86_64-apple-darwin11, OK for trunk?
> FX
>
Looks OK to me except for:
> - for (; i > 0; i--)
> + for (; i > 0;)
Might as well just make that a while loop.
Ciao!
Steven