This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, testsuite, committed] Test case for vectorization PR 32380
- From: Richard Guenther <rguenther at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Thomas Koenig <tkoenig at netcologne dot de>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 9 Feb 2012 12:53:18 +0100 (CET)
- Subject: Re: [patch, testsuite, committed] Test case for vectorization PR 32380
- References: <4F32D39B.5080202@netcologne.de> <20120209113249.GQ18768@tyan-ft48-01.lab.bos.redhat.com>
On Thu, 9 Feb 2012, Jakub Jelinek wrote:
> On Wed, Feb 08, 2012 at 08:57:15PM +0100, Thomas Koenig wrote:
> > I committed the attached test case after verifying that it passes and
> > that only real(4) variables occur (so the requiredment on vect_float
> > should be correct.)
>
> This fails e.g. on i686-linux. The problem is that dg-options for */vect/*
> tests overrides the standard options, instead of adding to them, so the
> -msse2 needed for the test to actually vectorize anything in it is gone.
>
> I think now that we have dg-additional-options, we can use it instead
> (at least, the testcase works with that), and perhaps we should eventually
> remove the magic testcase names like no-vfa-*, fast-math-*, no-fast-math-*,
> wrapv-* etc. and just use dg-additional-options in those vect.exp tests.
Yeah ... but IIRC dg-additional-options doesn't work everywhere
> Ok for trunk?
Ok.
Thanks,
Richard.
> 2012-02-09 Jakub Jelinek <jakub@redhat.com>
>
> PR fortran/32380
> * gfortran.dg/vect/pr32380.f: Use dg-additional-options instead
> of dg-options.
>
> --- gcc/testsuite/gfortran.dg/vect/pr32380.f.jj 2012-02-09 12:11:00.000000000 +0100
> +++ gcc/testsuite/gfortran.dg/vect/pr32380.f 2012-02-09 12:27:24.860308981 +0100
> @@ -1,6 +1,6 @@
> ! { dg-do compile }
> ! { dg-require-effective-target vect_float }
> -! { dg-options "-O3 -fcray-pointer -ftree-vectorize -fdump-tree-vect-stats" }
> +! { dg-additional-options "-O3 -fcray-pointer" }
> ! PR 32380 - loops were not vectorized due to unaligned store.
> subroutine trnfbt(e,f,qs,mte,gm,ihgenf,hgener,lft,llt,sthick,
> . fibl,istupd,ies,hoff)
>
>