This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, libfortran] PR 51646 Use POSIX mode flags
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Janne Blomqvist <blomqvist dot janne at gmail dot com>, Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Dec 2011 21:26:44 +0100
- Subject: Re: [Patch, libfortran] PR 51646 Use POSIX mode flags
- References: <CAO9iq9HXYmaXE7Adz+CaOKV34-YKRYZhQEG+mU6dGoZrrVAMjA@mail.gmail.com> <4EF205CE.9090309@net-b.de>
Dear All,
I would put Mike Long up with the people that climb the likes of K2!
A remarkable achievement that is nearly but not quite completely
useless. I hope that teh view made up fo it....
On the other hand, he helped us out :-)
Cheers
Paul
On Wed, Dec 21, 2011 at 5:14 PM, Tobias Burnus <burnus@net-b.de> wrote:
> On 12/21/2011 04:59 PM, Janne Blomqvist wrote:
>>
>> someone made some effort to build gfortran on an android phone (see
>> the PR). One problem was that libgfortran was using the old BSD
>> S_IREAD and S_IWRITE mode flags instead of the POSIX S_IRUSR and
>> S_IWUSR. The attached patch replaces the usage of these BSD flags with
>> the POSIX ones. I decided to omit any ifdef dance in case the target
>> doesn't support the POSIX flags, since it turns out that we have used
>> those unconditionally in io/unix.c going back at least to the 4.0
>> branch.
>>
>> Ok for trunk?
>
>
> OK. Thanks for the patch!
>
> Tobias
>
>
>> 2011-12-21 ?Janne Blomqvist<jb@gcc.gnu.org>
>> ? ? ? ?Tobias Burnus<burnus@net-b.de>
>>
>> ? ? ? ?PR libfortran/51646
>> ? ? ? ?* acinclude.m4 (LIBGFOR_CHECK_UNLINK_OPEN_FILE): Use POSIX mode
>> ? ? ? ?flags, omit mode argument when flags argument does not have
>> ? ? ? ?O_CREAT.
>> ? ? ? ?* io/unix.c (tempfile): Use POSIX mode flags.
>>
>>
>>
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
? ? ?? --Hitchhikers Guide to the Galaxy