This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [fortran, patches] Two short patches to review
On Wed, Nov 09, 2011 at 12:57:29AM +0100, FX wrote:
> >> -- 50404: refuse to have a CLOSE statement without a UNIT
> >> (F2008's C908 "A file-unit-number shall be specified in a
> >> close-spec-list") (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50404)
> >
> > jerry already approved this one.
>
> And I committed it as rev. , with a slight modification to add
> a decent locus (otherwise, the current locus is at a totally
> wrong place) and a testcase. Committed patch is attached.
Thanks!
> >> -- 50540: issue a normal error instead of an internal error, in
> >> conditions that could reasonably be triggered by invalid code
> >> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50540)
> >
> > Given that you've read the patch and my comments in the PR,
> > and that you've contributed/reviewed/committed hundreds of
> > patches, I think that this is sufficient review. I certainly
> > have no problems with committing the patch.
>
> Well, given the amount of compliment, I'm sure to screw up and then hide :)
> I'll get to it tomorrow morning, after some sleep.
Although I suspect you've been lurking in the background,
welcome back to the land of gfortran hacking. Your first
screw up is free, additional screw ups require you to
fix your screw up and fix an additional bug as your reward.
:-)
--
Steve