This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.

From: Thomas Koenig <tkoenig at netcologne dot de>
To: Janus Weil <janus at gcc dot gnu dot org>
Cc: Mikael Morin <mikael dot morin at sfr dot fr>, fortran at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 06 Aug 2011 20:55:41 +0200
Subject: Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
References: <CAKwh3qi6E=YrGir32itb2ggRUaKbvoxiQ+fG5aO6FQUVHNMPxw@mail.gmail.com> <CAKwh3qiYdy-SLr3-0QQfSCFAQ8DwFL=-CDRZLtu8Wbed+dy_ag@mail.gmail.com> <CAKwh3qgDCq80JOpoMf9McThP7RiE_CnaaPPbMB367sKKkYPkag@mail.gmail.com> <201108061946.35514.mikael.morin@sfr.fr> <CAKwh3qjZCRFRfU+ivXwHVaJxLzvjSRshLFFLZCjQZAx56yHCMA@mail.gmail.com>

Hi Janus,

+      /* Check string length.  */
+      if (proc_target->result->ts.type == BT_CHARACTER
+	&&  proc_target->result->ts.u.cl&&  old_target->result->ts.u.cl
+	&&  gfc_dep_compare_expr (proc_target->result->ts.u.cl->length,
+				   old_target->result->ts.u.cl->length) != 0)

This remains incorrect.

Please change that to a warning (at least) if gfc_dep_compare_expr returns -2.

Regards

Thomas

Follow-Ups:
- Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Janus Weil

References:
- [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Janus Weil
- Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Janus Weil
- Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Janus Weil
- Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Mikael Morin
- Re: [Patch, Fortran, OOP] PR 49638: [OOP] length parameter is ignored when overriding type bound character functions with constant length.
  - From: Janus Weil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]