Re: PR 49755 - Patch finished but I have questions.

[Tobias Burnus <burnus at net-b dot de>]

On 07/26/2011 09:49 AM, Daniel Carrera wrote:
> On 07/26/2011 09:15 AM, Tobias Burnus wrote:
> > Secondly, I wonder what happens if malloc fails. In the current code,
> > one directly modifies the variable such that afterwards the one has a
> > pointer to NULL. I think from the wording of the standard, one would
> > keep the current allocation status. I think one might need to
> > reintroduce a temporary variable for the case that malloc fails.
>
> Are you sure? If the variable *has* any sort of existing allocation, 
> the code will never reach the malloc line. The malloc only happens if 
> the variable is not already allocated, in which case, the malloc is 
> not destroying anything.

Good point! I concur that it shouldn't change the value.

Tobias