This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: Small patches or big patches?
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Daniel Carrera <dcarrera at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>
- Date: Fri, 8 Jul 2011 15:00:53 -0700
- Subject: Re: Small patches or big patches?
- References: <4E177B9B.2010306@gmail.com>
On Fri, Jul 08, 2011 at 11:50:19PM +0200, Daniel Carrera wrote:
>
> Right now I am working on a patch to implement the stat= and errmsg=
> parameters of an ALLOCATE statement with the coarray_lib option.
>
> ALLOCATE( x(10)[*] , stat=s, errmsg=str )
> principle be submitted as a small patch in its own right. So here is my
> question: Is it better to submit a small but functional intermediary
> patch like this one, or should I wait until "errmsg=" is also
> implemented before I submit anything?
>
In general, small patches are easier to review and 6 months
later when a bug is reported, it is easier to go back to see
what was changed.
IMHO, patches, whether large or smaller, that address several
unrelated issues should be split up into smaller self-contained
patches.
--
Steve