This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: First Patch
- From: Daniel Kraft <d at domob dot eu>
- To: Daniel Carrera <dcarrera at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>
- Date: Tue, 07 Jun 2011 21:07:21 +0200
- Subject: Re: First Patch
- Openpgp: id=A3B53998
- References: <4DEDF993.3070502@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Daniel and all,
On 06/07/11 12:12, Daniel Carrera wrote:
> I'd like to submit my first patch for my Google Summer of Code project.
in addition to what Tobias alreay wrote, I just have a minor comment:
@@ -164,7 +160,6 @@
}
/* TODO: Is ierr correct? When should STAT_STOPPED_IMAGE be used? */
- - return ierr;
}
I didn't look at the context in detail, but from a quick glance it seems
to me that after you removed the return the comment doesn't make much
sense any longer. So probably you want to update it as well? Possibly
move up to where you set the return value or something.
Thanks for joining the gfortran team! I'm really looking forward to
full co-array support at some point in the future. (And am really sorry
that at the moment I can't contribute much because of lack of time.)
Yours,
Daniel
- --
http://www.pro-vegan.info/
- --
Done: Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIVAwUBTe526VJ+ebqjtTmYAQLYnxAAnokgRLeEiH7SvpwC3PVwZjqkmDEJHbkV
KKGp8NmRt/P+aiFLfSyzgxs1aQB6UUZft98Ik3YOFqm2eFHMTMCoTuzk9fjfjnul
IOsWr0kvwybuMoG6fGmky9U0UD9gQ3WZn8LDV69e+a2YyntDOQ1eLU5DBwX2gxOz
x35Qvri1VqGPZyeJuSZLbEFV5/O5q507DR0sMZp1f4OuWwQySbuU5COisphElMJl
E7ADatV+0Cdha8MT16NgiBIa1phyYjj36CxSlPMAVugp3CpJCKKbbESdLQyrgo3h
JJ4J6e/wXLahGso25jKVCtIkJFKeRneRSQlkQtrsOJdn3rMUwd+q34FIDRrEJ489
KweB7nd1xtfTcB5m3omNcYORIAExPhbqd9SyElluFiHCGjd0VmDcO8D+pL302XZk
X3WQKtbQMv/2WgM3lbX185mN2b2mduYdlp2UNl/QFsnCmc1nFmmFIwkC380S5wVp
u5XyLFAgluFXc/EHc9KZppy7Gy1Q5iD2NcVk4a0YTLPCG5TCQmInzNvTKG6YHvcD
oYwD+2U27D7YC0iLtvozl0v9Aaq/uDixjwRYM40unx7lelIehWdIsVfDJnuLvUdW
gy0zl8swgJU2aLUXGolXjeHp0HGoqWomBYTxhFpwoh3MpzjXG4LD6WwxsjJyx2Gd
j9sApDlcHEA=
=Htya
-----END PGP SIGNATURE-----