This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Re: avoid useless if-before-free tests


Tom Tromey wrote:
>>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:
>
> Jim> Since v3, I've rebased these and moved the fortran changes to precede
> Jim> these (changing gfc_free to free introduced a few more instances
> Jim> that this transformation deals with).  As mentioned before, the
> Jim> conditional-removing transformation was done mechanically with
> Jim> two manual corrections.  One to deal with a following "else",
> Jim> and another to restore a conditional that should not have been
> Jim> removed.
>
> I'm not sure if this needs a review (I forgot what happened on the last
> thread) but for avoidance of doubt, the java bits are ok.

Thanks.  I wasn't sure either.
I'll presume it's ok and commit tomorrow if no one says otherwise,
since some people actually did review (and spot the invalid
transformation that I've since corrected).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]