This is the mail archive of the
mailing list for the GNU Fortran project.
Re: [PATCH v3] Re: avoid useless if-before-free tests
- From: Jim Meyering <jim at meyering dot net>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, gcc mailing list <gcc at gcc dot gnu dot org>
- Date: Fri, 15 Apr 2011 10:23:17 +0200
- Subject: Re: [PATCH v3] Re: avoid useless if-before-free tests
- References: <firstname.lastname@example.org> <Pine.LNX.email@example.com> <firstname.lastname@example.org> <email@example.com> <AANLkTimAfkfmmfxrNp4w_wD2rGiQ7x07esgtVDT_-8Cj@mail.gmail.com> <firstname.lastname@example.org> <BANLkTi=Dw4Qwh0cr1hfscpKYpkQp0SaVkg@mail.gmail.com> <email@example.com> <BANLkTikn26WgZm3f-RcqGtmeCS=52tvNug@mail.gmail.com>
Janne Blomqvist wrote:
> On Fri, Apr 15, 2011 at 10:54, Jim Meyering <firstname.lastname@example.org> wrote:
>> Janne Blomqvist wrote:
>>> On Thu, Mar 24, 2011 at 18:51, Jim Meyering <email@example.com> wrote:
>>>> Janne Blomqvist wrote:
>>>>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering <firstname.lastname@example.org> wrote:
>>>>>> Relative to v2, I've added libgo/ to the list of exempt
>>>>>> directories and added
>>>>>> this recently discussed gfc_free patch, at the request of Tobias Burnus.
>>>>>> Also, I corrected an error in fortran's ChangeLog and removed all
>>>>>> whitespace changes from all ChangeLog files.
>>>>> The libgfortran changes are Ok for 4.7.
>>>>> For the gfortran frontend (gcc/fortran/*) I'd prefer if you'd
>>>>> - Replace all calls to "gfc_free (x)" with "free (x)".
>>>>> - Remove the gfc_free() function and prototype.
>>>>> - Remove the free() macro which currently prevents calling free() directly.
>>>> Following up, I've refreshed the series but hit a minor snag
>>>> while converting new uses of gfc_free, removing new tests-before-free
>>>> and merging/reordering changes.
>>>> Applying this fix first makes my problem go away:
>>> So, what's the plan here? Do you plan to get a GCC account, do you
>>> already have one, or what? Now that 4.7 is open for development, it's
>>> perhaps the right time to poke the maintainers to get this patch in.
>>> If you don't have a GCC account, as one of the Fortran maintainers I
>>> can commit the Fortran and libgfortran parts, but someone else will
>>> have to do the rest (were they ever approved, BTW?) as I have only
>>> write after approval privileges for the rest of GCC.
>> Can someone add me to the gcc group? ?That would help.
>> I already have ssh access to sourceware.org.
> According to http://gcc.gnu.org/svnwrite.html , you should send an
> email to overseers(at)gcc.gnu.org . It says that you need a sponsor
> and "The steering committee or a well-established GCC maintainer
> (including reviewers) can approve for write access any person with GNU
> copyright assignment papers in place and known to submit good
> patches.". I'm not sure if I'm considered to be well-established
> enough, so could someone help Jim out here, please?
> Or, if nobody pipes up within a few days, just mention my name as your
> sponsor and we'll see if the overseers consider me well-established or
> not.. ;)
FYI, I have an "ANY" assignment on file, so no need to wait for paperwork.