This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[libgfortran, patch] Fix fd leak in unix .c’s fallback_access(), aka PR 4516 5

From: FX <fxcoudert at gmail dot com>
To: gcc-patches at gcc dot gnu dot org, gfortran List <fortran at gcc dot gnu dot org>
Date: Sat, 26 Feb 2011 16:11:45 +0100
Subject: [libgfortran, patch] Fix fd leak in unix .c’s fallback_access(), aka PR 4516 5

The attached patch fixes a file descriptor leak in fallback_access(), a function in io/unix.c for systems without a system access() (which happens on newlib systems); this is PR 45165.

The patch was tested by building and regtesting on x86_64-darwin, simulating the lack of access() by overriding libgfortran configure results. OK to commit to trunk?

Cheers,
FX

PS: I don't think it's worth backporting, as it's only a leak on newlib systems

Attachment: fd_leak.ChangeLog
Description: Binary data

Attachment: fd_leak.diff
Description: Binary data

Follow-Ups:
- Re: [libgfortran, patch] Fix fd leak in unix.c’s fallback_access(), aka PR 45165
  - From: Jerry DeLisle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]