This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
[Patch, Fortran] PR 47042: ICE on invalid code: Missing interface check
- From: Tobias Burnus <burnus at net-b dot de>
- To: gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Sun, 30 Jan 2011 13:40:03 +0100
- Subject: [Patch, Fortran] PR 47042: ICE on invalid code: Missing interface check
Build and regtested on x86-64-linux.
OK for the trunk?
(At least part of the ICE is in a way a regression: with proc-pointers,
external + pointer became valid - thus some other checks disappeared.)
Tobias
2011-01-31 Tobias Burnus <burnus@net-b.de>
PR fortran/47042
* interface.c (gfc_procedure_use): Add explicit interface check for
pointer/allocatable functions.
2011-01-31 Tobias Burnus <burnus@net-b.de>
PR fortran/47042
* gfortran.dg/interface_34.f90: New.
diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index 1cbba24..1e5df61 100644
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -2686,6 +2686,30 @@ gfc_procedure_use (gfc_symbol *sym, gfc_actual_arglist **ap, locus *where)
if (sym->attr.if_source == IFSRC_UNKNOWN)
{
gfc_actual_arglist *a;
+
+ if (sym->attr.pointer)
+ {
+ gfc_error("The pointer object '%s' at %L must have an explicit "
+ "function interface or be declared as array",
+ sym->name, where);
+ return;
+ }
+
+ if (sym->attr.allocatable && !sym->attr.external)
+ {
+ gfc_error("The allocatable object '%s' at %L must have an explicit "
+ "function interface or be declared as array",
+ sym->name, where);
+ return;
+ }
+
+ if (sym->attr.allocatable)
+ {
+ gfc_error("Allocatable function '%s' at %L must have an explicit "
+ "function interface", sym->name, where);
+ return;
+ }
+
for (a = *ap; a; a = a->next)
{
/* Skip g77 keyword extensions like %VAL, %REF, %LOC. */
--- /dev/null 2011-01-30 09:39:30.783999991 +0100
+++ gcc/gcc/testsuite/gfortran.dg/interface_34.f90 2011-01-30 11:35:02.000000000 +0100
@@ -0,0 +1,33 @@
+! { dg-compile }
+!
+! PR fortran/47042
+!
+! Contribued by Jerry DeLisle
+!
+
+program bug
+
+contains
+function get_cstring ()
+ character :: get_cstring
+ character, pointer :: ptmp
+ character, allocatable :: atmp
+
+ get_cstring = ptmp(i) ! { dg-error "must have an explicit function interface" }
+ get_cstring = atmp(i) ! { dg-error "must have an explicit function interface" }
+end function
+
+function get_cstring2 ()
+ EXTERNAL :: ptmp, atmp
+ character :: get_cstring2
+ character, pointer :: ptmp
+ character, allocatable :: atmp
+
+ get_cstring2 = atmp(i) ! { dg-error "must have an explicit function interface" }
+
+ ! The following is regarded as call to a procedure pointer,
+ ! which is in principle valid:
+ get_cstring2 = ptmp(i)
+end function
+
+end program