This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR41859 ICE on invalid expression involving DT with pointer components in I/O


On 08/18/2010 06:30 AM, Jerry DeLisle wrote:
On 08/17/2010 10:58 PM, Paul Richard Thomas wrote:
Dear Jerry,

OK for trunk?

OK but for one tiny question:


Should you not check for parentheses, just to stop the code trying to
charge down, for example, binary operators? Since expr1 has been
resolved already at the top of resolve_code, this should not matter -
it's just unnecessary.


I was thinking of a case like this:


print *, (-p)

Where p is invalid. We need to drill down to run the check on it.

I decided to try the above case and it gets caught earlier by unary operator checks so your suggestion should work well. I will regression test it and commit if OK.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]