This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR fortran/36928 - array dependencies
- From: Tobias Burnus <burnus at net-b dot de>
- To: Thomas Koenig <tkoenig at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 30 May 2010 19:10:27 +0200
- Subject: Re: [patch, fortran] PR fortran/36928 - array dependencies
- References: <1275220993.4579.37.camel@linux-fd1f.site>
Thomas Koenig wrote:
> here is a patch to handle interleaving array dependencies. This should
> handle the most common cases.
>
You should add a short comment on the algorithm thus one can quickly
check it, e.g.
"No dependency if reminder of (l_start - r_start)/gcd(l_stride,
r_stride)) is nonzero."
At least it took me a short while to translate the GMP functions into
the string above.
(Additionally, I felt better, if you would add a run-test and include
also some checks that the temporary is still generated in some commen
cases. I am always worrying that on introduces bugs in such cases.)
> Regression-tested on x86_64-unknown-linux-gnu. OK for trunk?
>
OK with considering the nit above.
Tobias