This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] PR41167 - ICE with PACK() and string concatenation
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Tobias Burnus <burnus at net-b dot de>, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Cc: fortran at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 23 Jan 2010 16:42:25 +0100
- Subject: Re: [Patch, fortran] PR41167 - ICE with PACK() and string concatenation
- References: <339c37f21001230412n5091c084lc6b3bec6e1a8de62@mail.gmail.com> <4B5B02D0.1050901@net-b.de>
Dear Tobias and Dominique,
No - that is not an acceptable side-effect of the fix. I missed that
it did that.
I'll fix the simplifier. I have to confess that the source of the
problem took a long time to find. A better fix should be much
quicker!
Cheers
Paul
On Sat, Jan 23, 2010 at 3:08 PM, Tobias Burnus <burnus@net-b.de> wrote:
> On 23 January 2010 13:12, Paul Richard Thomas wrote:
>> Herewith a fix for one of our 'serious' PRs. ?It's self-explanatory.
>> Bootstrapped and regtested on FC9/x86_64 - OK for trunk?
>>
> The work-around patch is OK; it has the disadvantage of causing the same
> error printed multiple times (as Dominique noted) and it is not a real
> fix, but it fixes the problem. A proper fix of the simplifier would be
> much better, of cause.
>
> Tobias
>
>> 2010-01-23 ?Paul Thomas ?<pault@gcc.gnu.org>
>>
>> ? ? ? PR fortran/41167
>> ? ? ? * resolve.c (resolve_operator): Try simplification on temporary
>> ? ? ? expression and check type before copying.
>>
>> 2010-01-23 ?Paul Thomas ?<pault@gcc.gnu.org>
>>
>> ? ? ? PR fortran/41167
>> ? ? ? * gfortran.dg/char_array_arg_1.f90 : New test.
>> ? ? ? * gfortran.dg/pr25923.f90 : Remove XFAIL.
>>
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy